RTEMS | bsps/stm32h7: Add DMA support for SPI (!294)

Joel Sherrill (@joel) gitlab at rtems.org
Wed Nov 6 18:50:20 UTC 2024



Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on bsps/arm/stm32h7/dma/dma-allocator.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294#note_114414

 > +{
 > +  switch (base) {
 > +  case DMA1_Stream0_BASE:

Is there any chance one of the constants can be 0? This would conflict with the return 0 at the bottom.

--
  
Joel Sherrill started a new discussion on bsps/arm/stm32h7/spi/spi-support.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294#note_114415

 > +  }
 > +#endif
 > +  if (ctx->spi.hdmatx == NULL) {

Blank line between the #endif and the if.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/294
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241106/4b25f1ee/attachment.htm>


More information about the bugs mailing list