RTEMS | Draft: posix/aio: Implemented aio_suspend() (!275)

Mon Nov 11 09:43:27 UTC 2024

Alessandro Nardin commented on a discussion on cpukit/posix/src/aio_suspend.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/275#note_114699

 > +  if ( timeout == NULL ){
 > +    result = rtems_event_system_receive(
 > +      RTEMS_EVENT_SYSTEM_AIO_SUSPEND,
 > +      RTEMS_DEFAULT_OPTIONS,
 > +      RTEMS_NO_TIMEOUT,
 > +      &event_out
 > +    );
 > +  }else {
 > +    long ticks = rtems_timespec_to_ticks( timeout );
 > +    result = rtems_event_system_receive(
 > +      RTEMS_EVENT_SYSTEM_AIO_SUSPEND,
 > +      RTEMS_WAIT,
 > +      ticks,
 > +      &event_out
 > +    );  
 > +  }

I realized that part was unnecessarily long, so I refactored it to make it more compact. Do you think it still needs to be extracted into a helper function, or is it good as it is now?

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/275#note_114699
You're receiving this email because of your account on gitlab.rtems.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241111/ca528b0d/attachment-0001.htm>