RTEMS | Draft: add programmatic interface for data produced by cpuuse (!232)

Kinsey Moore (@opticron) gitlab at rtems.org
Fri Oct 11 12:38:06 UTC 2024



Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232 was reviewed by Kinsey Moore

--
  
Kinsey Moore started a new discussion on cpukit/include/rtems/cpuuse.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232#note_113090

 >  
 > +
 > +

Remove these extra lines that were added. There are other extra lines added in this patch that are not necessary.

--
  
Kinsey Moore started a new discussion on cpukit/include/rtems/cpuuse.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232#note_113091

 > + * @brief Contains the data for the cpuuse data.
 > + */
 > +typedef struct {

Indentation and formatting of the lines within this struct are not consistent. Additionally, the @brief documentation should be more descriptive.

--
  
Kinsey Moore started a new discussion on cpukit/include/rtems/cpuuse.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232#note_113092

 > +
 > +   /**
 > +   * @brief name of the  thread.

Accidental double space, check for more of these.

--
  
Kinsey Moore started a new discussion on cpukit/include/rtems/cpuuse.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232#note_113093

 > +
 > +   /**
 > +   * @brief system uptime since last restart .

Extra space before the period at the end. This issue exists elsewhere, as well.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241011/158200c5/attachment.htm>


More information about the bugs mailing list