RTEMS | GRLIB: Fix Coverity issues (!256)

Sebastian Huber (@sebhub) gitlab at rtems.org
Fri Oct 18 13:25:06 UTC 2024




Sebastian Huber commented on a discussion on bsps/shared/grlib/ascs/grascs.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/256#note_113275

 >      return -GRASCS_ERROR_TRANSACTIVE;
 >    }
 >    
 > -  cfg->regs->cmd = ((cfg->regs->cmd &= ~GRASCS_CMD_SLAVESEL) |
 > -		    (slave << GRASCS_CMD_SLAVESEL_BITS));
 > +  cfg->regs->cmd &= ~GRASCS_CMD_SLAVESEL
 > +  cfg->regs->cmd |= (slave << GRASCS_CMD_SLAVESEL_BITS);

Could you please rebase the commits so that we have only one commit touching bsps/shared/grlib/ascs/grascs.c.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/256#note_113275
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241018/463a1f29/attachment.htm>


More information about the bugs mailing list