RTEMS | waf: Fix handling of the VERSION file in a release (!257)

[Chris Johns (@chris)]

Chris Johns commented on a discussion on wscript: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/257#note_113388

 > +    from waflib.Errors import WafError
 > +    release_label = "not-released"
 > +    try:
 > +        modified = ctx.cmd_and_log("git ls-files --modified",
 > +                                   quiet=Context.BOTH).strip()
 > +        release_label = ctx.cmd_and_log("git rev-parse --short HEAD",
 > +                                        quiet=Context.BOTH).strip()
 > +        if len(modified) != 0:
 > +            release_label += "-modified"
 > +    except WafError:
 > +        pass
 > +    return release_label
 > +
 > +
 > +#
 > +# This class is not aligned the project's release labelling. It will

Yes and it is also wrong in 5. There are many interfaces that have changed over the years and this is one we need to clean up.

The VC key is not being removed in 6 and I am giving notice it needs to be removed. We should not overlap functionality in interfaces and VC key is to specific and does not fit the needed purpose of the release label.

I am sorry I have not been more accurate about this in the past. I have now had to time to deal with this and I believe this interface will be serve us into the future.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/257#note_113388
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241021/e1632ae7/attachment.htm>