RTEMS | waf: Fix handling of the VERSION file in a release (!257)
Chris Johns (@chris)
gitlab at rtems.org
Sat Oct 26 21:50:25 UTC 2024
Chris Johns commented on a discussion on wscript: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/257#note_113829
> - try:
> - value = cp.get("RTEMS_VERSION", key)
> - version[key] = no_unicode(value)
> - except configparser.NoOptionError:
> - pass
> + try:
> + value = no_unicode(cp.get("version", "revision"))
> + # The revision is <major>.<minor>[-label]
> + # break is up and update the version
> + if "." not in value:
> + ctx.fatal("Invalid VERSION revision: no dot")
> + vs = value.split(".", 1)
> + version_major = vs[0]
> + vs[0] = vs[1]
> + if "." in vs[0]:
> + ctx.fatal("Invalid VERSION revision: too many dots")
Yes the VC key (`git` hash) was delimited with a `.`. I prefer it to be `-` but that would not be compatible with the labeling up to this point in the ^ code. If we are happy to make the change I can do that?
It would make this piece of the documentation simpler:
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/blob/main/eng/release-process.rst?ref_type=heads&plain=1#L116
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/257#note_113829
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241026/648ea52c/attachment-0001.htm>
More information about the bugs
mailing list