RTEMS | waf: Fix handling of the VERSION file in a release (!257)

Chris Johns (@chris) gitlab at rtems.org
Sat Oct 26 21:53:01 UTC 2024




Chris Johns commented on a discussion on wscript: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/257#note_113830

 > +            value = no_unicode(cp.get("version", "revision"))
 > +            # The revision is <major>.<minor>[-label]
 > +            # break is up and update the version
 > +            if "." not in value:
 > +                ctx.fatal("Invalid VERSION revision: no dot")
 > +            vs = value.split(".", 1)
 > +            version_major = vs[0]
 > +            vs[0] = vs[1]
 > +            if "." in vs[0]:
 > +                ctx.fatal("Invalid VERSION revision: too many dots")
 > +            if "-" in vs[0]:
 > +                value = vs[0]
 > +                vs = value.split("-", 1)
 > +                version_label = vs[1]
 > +            version_minor = vs[0]
 > +            prefix = "/opt/rtems/" + version_major

The `prefix` is version specific so it changes when the major number changes. The code was refactored to parse `VERSION` and set these values when the help is displayed as it was incorrectly printing the defaults before.

Also the prefix as it is does not handle Windows cleanly but that is a separate issue.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/257#note_113830
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241026/9e70b538/attachment-0001.htm>


More information about the bugs mailing list