RTEMS | grlib/b1553rt: Fix bit shift direction (!273)

Sebastian Huber (@sebhub) gitlab at rtems.org
Tue Oct 29 10:49:20 UTC 2024




Sebastian Huber started a new discussion on bsps/shared/grlib/1553/b1553rt.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/273#note_113961

 >          tsw = READ_DMA(&rt->mem[tx*0x3E0+suba]); 
 >  
 >          /* Build Message Information Word (B1553BRM-style) */
 > -        miw = (wc<<11) | (tsw&RT_TSW_BUS)>>4 | !(tsw&RT_TSW_OK)>>7 | (tsw&RT_TSW_ILL)>>5 | 

Given the surrounding style and

```
#define RT_TSW_OK  (1<<14)
```

I would just remove the `!` and keep the shift as it is.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/273#note_113961
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241029/6f1a6fa5/attachment-0001.htm>


More information about the bugs mailing list