RTEMS | bsp/xilinx-zynq: Add devcfg and slcr drivers (!283)

[Gedare Bloom (@gedare)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/283 was reviewed by Gedare Bloom

--
  
Gedare Bloom started a new discussion on bsps/arm/xilinx-zynq/dev/devcfg/zynq-devcfg.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/283#note_114062

 > +/*

Add SPDX to all files. Preferably break apart this comment block according to https://docs.rtems.org/branches/master/eng/coding-file-hdr.html#file-templates

--
  
Gedare Bloom started a new discussion on bsps/arm/xilinx-zynq/dev/devcfg/zynq-devcfg.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/283#note_114063

 > + * Author: Patrick Gauvin <gauvin at hcs.ufl.edu>
 > + */
 > +#include <stdio.h>

including a driver like this shouldn't need stdio? maybe protect it with the DEBUG CPP checks for the print debugging

--
  
Gedare Bloom started a new discussion on bsps/arm/xilinx-zynq/dev/devcfg/zynq-devcfg.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/283#note_114064

 > +#include <dev/devcfg/zynq-devcfg-regs.h>
 > +
 > +#define WARN( msg ) printf( "%s:%s: %s", __FILE__, __func__, msg )

printk would be preferable at this level. could also wrap this in a DEBUG CPP check especially if printf is needed. looks like ZYNQ_DEVCFG_DEBUG is used below.

--
  
Gedare Bloom started a new discussion on bsps/arm/xilinx-zynq/dev/devcfg/zynq-devcfg.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/283#note_114065

 > +  data.current_task = RTEMS_INVALID_ID;
 > +  data.write_mode_restricted = true;
 > +  status = rtems_semaphore_create(

these need to be accounted for in confdefs


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/283
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241030/2b75e6f8/attachment-0001.htm>