RTEMS | stm32h7: Resolve warnings and add SPI support (!204)
Cedric Berger (@cedric)
gitlab at rtems.org
Fri Sep 6 17:30:48 UTC 2024
Cedric Berger commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/204#note_111839
Hello Kinsey, thanks for doing that.
I'm in the train reading your patch, `stm32h7_spi_transfer()` specifically, and I've one comment:
SPI can be full-duplex, And I think you don't handle the case where both a TX and RX buffer are provided.
In that function, if `(msg->rx_buf != NULL && msg->tx_buf != NULL)`, then you should call `HAL_SPI_TransmitReceive()`, and not `HAL_SPI_Transmit()` followed by `HAL_SPI_Receive()`
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/204#note_111839
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240906/a36cb26f/attachment.htm>
More information about the bugs
mailing list