RTEMS | dev/serial/zynq: Improve baud calculation and simplify code (!199)

Sebastian Huber (@sebhub) gitlab at rtems.org
Thu Sep 12 00:07:51 UTC 2024




Sebastian Huber commented on a discussion on bsps/shared/dev/serial/zynq-uart-polled.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/199#note_111949

 >      | ZYNQ_UART_MODE_PAR(ZYNQ_UART_MODE_PAR_NONE)
 >      | ZYNQ_UART_MODE_CHRL(ZYNQ_UART_MODE_CHRL_8)
 >      | mode_clks;
 > -
 > -  while (zynq_uart_read_char_polled(regs) >= 0) {
 > -    /* Drop */
 > -  }
 > -
 > -  zynq_uart_reset_tx_flush(regs);

The `zynq_uart_initialize()` waits for the TX FIFO to be empty and TX to be inactive before it changes the settings. This patch removes code which was done after the settings were applied.

The patch is seven months old picked up from the mailing list. I would prefer to not change it just to get a better commit message.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/199#note_111949
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240912/6fa1d4a5/attachment-0001.htm>


More information about the bugs mailing list