RTEMS | Draft: add programmatic interface for data produced by cpuuse (!232)

[Sebastian Huber (@sebhub)]

Sebastian Huber started a new discussion on cpukit/libmisc/cpuuse/cpuusagereport.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232#note_112327

 >    const rtems_printer *printer;
 >    Timestamp_Control    total;
 >    Timestamp_Control    uptime_at_last_reset;
 > +  bool  (*usage_function_pointer) ( Thread_Control *the_thread, void * arg, char *  name ,  uint32_t   ival, uint32_t  fval , uint32_t  seconds ,uint32_t  nanoseconds);
 >  } cpu_usage_context;
 >  
 > -static bool cpu_usage_visitor( Thread_Control *the_thread, void *arg )
 > +bool  print_usage_stats( Thread_Control *the_thread, 
 > +                                         void * arg, 
 > +                                         char *  name ,  
 > +                                         uint32_t ival, 
 > +                                         uint32_t fval , 
 > +                                         uint32_t  seconds ,
 > +                                         uint32_t  nanoseconds

Functions with so many parameters will cause API change issues in the future. Please create a structure with members. Also the members need to be better named with a Doxygen documentation for each member. Since the cpuuse.h is a generated file, it would be nice to add the interface specification to rtems-central:

https://docs.rtems.org/branches/master/eng/req/howto.html#interface-specification

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/232#note_112327
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240920/578647ab/attachment-0001.htm>