RTEMS | uC5282 console.c has warnings for misleading indentation (#5243)

Joel Sherrill (@joel) gitlab at rtems.org
Fri Apr 25 15:31:18 UTC 2025



Joel Sherrill created an issue: https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5243



## Summary
These warnings are from the uC5282 console.c file. The file uses a mix of tabs and spaces which appears to be the cause of this warning. But the code definitely looks incorrectly indented if tabs are 8 spaces. RTEMS style does not allow tabs.

```
../../../bsps/m68k/uC5282/console/console.c: In function '_BSP_null_char':
../../../bsps/m68k/uC5282/console/console.c:49:5: warning: this 'while' clause does not guard... [-Wmisleading-indentation]
   49 |     while ( (MCF5282_UART_USR(CONSOLE_PORT) & MCF5282_UART_USR_TXRDY) == 0 )
      |     ^~~~~
In file included from ../../../cpukit/include/rtems/score/isr.h:41,
                 from ../../../cpukit/include/rtems/config.h:65,
                 from ../../../cpukit/include/rtems.h:59,
                 from ../../../cpukit/include/rtems/libio.h:55,
                 from ../../../bsps/m68k/uC5282/console/console.c:24:
../../../cpukit/include/rtems/score/isrlevel.h:94:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'while'
   94 |   do { \
      |   ^~
../../../cpukit/include/rtems/rtems/intr.h:311:49: note: in expansion of macro '_ISR_Local_enable'
  311 |   #define rtems_interrupt_enable( _isr_cookie ) _ISR_Local_enable( _isr_cookie )
      |                                                 ^~~~~~~~~~~~~~~~~
../../../bsps/m68k/uC5282/console/console.c:51:9: note: in expansion of macro 'rtems_interrupt_enable'
   51 |         rtems_interrupt_enable(level);
      |         ^~~~~~~~~~~~~~~~~~~~~~

[ 121/4617] Compiling cpukit/posix/src/getitimer.c
```



## Steps to reproduce


### Pre-set options

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5243
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250425/c7b412bf/attachment.htm>


More information about the bugs mailing list