RTEMS | Add dladdr() support to RTEMS (!679)

[Gedare Bloom (@gedare)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679 was reviewed by Gedare Bloom

--
  
Gedare Bloom started a new discussion on cpukit/libdl/rtl.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679#note_129176

 > +  {
 > +    rtems_rtl_obj_sym* sym = &obj->global_table[i];
 > +    

is `sym != NULL` guaranteed here? 
maybe add an assert?

--
  
Gedare Bloom started a new discussion on cpukit/libdl/rtl.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679#note_129177

 > +        
 > +        if (sym->value == addr)
 > +          return best_sym;

this could be pulled out, put before line 1000, then change the `<=` to `<`.

--
  
Gedare Bloom started a new discussion on cpukit/libdl/rtl.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679#note_129178

 > +  {
 > +    rtems_rtl_obj_sym* sym = &obj->local_table[i];
 > +    

same comments here as above.

--
  
Gedare Bloom started a new discussion on testsuites/libtests/dl14/dl-load.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679#note_129179

 > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 > + * POSSIBILITY OF SUCH DAMAGE.
 > + */

add blank line after the comment block

--
  
Gedare Bloom started a new discussion on testsuites/libtests/dl14/dl-load.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679#note_129180

 > + * POSSIBILITY OF SUCH DAMAGE.
 > + */
 > +int dl_load_test(void);

header guards?

--
  
Gedare Bloom started a new discussion on testsuites/libtests/dl14/dl14.doc: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679#note_129181

 > +/* SPDX-License-Identifier: BSD-2-Clause */

I think we use `#` for text "comments"


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/679
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250821/5feca468/attachment-0001.htm>