RTEMS | bsp/aarch64/raspberrypi: Add I2C interrupt support (!682)

[Christian Mauderer (@c-mauderer)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/682 was reviewed by Christian Mauderer

--
  
Christian Mauderer started a new discussion on bsps/aarch64/raspberrypi/i2c/raspberrypi-i2c.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/682#note_129135

 > +#ifdef BSP_I2C_USE_INTERRUPTS
 > +    C_REG( bus ) |= C_INTD;
 > +    if ( rtems_event_transient_receive( RTEMS_WAIT, bus->base.timeout ) !=

I know that the transient event is used in a lot of drivers. But usually I prefer the self-contained binary semaphores over the transient events. Advantage is: If some driver goes crazy and sends transient events to random tasks, this will brake. In comparison, the self-contained binary semaphore can only be triggered by this driver. For an example take a look here:

https://gitlab.rtems.org/rtems/rtos/rtems/-/blob/main/bsps/arm/imxrt/i2c/imxrt-lpi2c.c?ref_type=heads#L136

Like I said: The transient is used in a lot of drivers. So if you don't want to change it, I can accept that too.

--
  
Christian Mauderer started a new discussion on bsps/aarch64/raspberrypi/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/682#note_129136

 >   */
 >  
 > -#define BCM2835_INTC_TOTAL_IRQ       216

These changes seem to be unrelated. Can you split them into two commits. One for fixing the formatting in the files and one for the interrupt?

--
  
Christian Mauderer started a new discussion on spec/build/bsps/aarch64/raspberrypi/opti2cirq.yml: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/682#note_129137

 > +format: '{}'
 > +links: []
 > +name: BSP_I2C_USE_INTERRUPTS

Is there a reason that you want to keep the polled version? I think most BSPs just drop the support for polling as soon as interrupts are supported.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/682
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250821/317a1f3d/attachment-0001.htm>