RTEMS | cpukit/posix Added pthread clock functions (!547)
Joel Sherrill (@joel)
gitlab at rtems.org
Wed Jul 16 21:32:47 UTC 2025
Joel Sherrill commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/547#note_126671
@mez3n This is your commit message. There are two words spelled incorrectly in it. (@amar More hints that codespell is needed on commits.)
```
Added
pthread_cond_clockwait()
pthread_mutex_clocklock()
pthread_rwlock_clockrdlock()
pthread_rwlock_clockwrlock()
with tests as a part of my work for GSoC 25
I followed the timed verisons of these functions
as a refrence.
```
But these are secondary to improving the commit message itself. It should include that these are new in POSIX Issue 8. It should "update" any related issues. There is https://gitlab.rtems.org/rtems/programs/gsoc/-/issues/69 for POSIX Issue 8 specifically. There may also be an epic tracking this work also. There is also no need to mention GSoC.
A better message might be something like this:
```
Added pthread_cond_clockwait(), pthread_mutex_clocklock(),
pthread_rwlock_clockrdlock(), and pthread_rwlock_clockwrlock()
that are new in POSIX Issue 8. Also added tests.
The implementation used the timed versions of these functions
as a reference.
Updates @whatever@
```
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/547#note_126671
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250716/27d69485/attachment.htm>
More information about the bugs
mailing list