RTEMS | mvme3100 fixes (!541)

Fri Jul 25 01:46:16 UTC 2025

Kinsey Moore started a new discussion on cpukit/libcsupport/src/open_dev_console.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/541#note_127435

 >   */
 >  void rtems_libio_post_driver(void)
 >  {
 > +  int fd = 0;
 >    /*
 >     * Attempt to open /dev/console.
 >     */
 > -  if ( open( CONSOLE_DEVICE_NAME, O_RDONLY, 0 ) != STDIN_FILENO ) {
 > +  if ( ( fd = open( CONSOLE_DEVICE_NAME, O_RDONLY, 0 ) ) != STDIN_FILENO ) {
 >      /*
 >       * There may not be a console driver so this is OK.
 >       */
 > -    return;
 > +    if ( fd < 0 )
 > +      return;
 > +

This if statement needs braces.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/541#note_127435
You're receiving this email because of your account on gitlab.rtems.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250725/589d2ae1/attachment-0001.htm>