Re: RTEMS | cpukit/shell​​ supports using the tab key to auto-complete commands (!495)

[Chris Johns (@chris)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/495 was reviewed by Chris Johns

--
  
Chris Johns started a new discussion on cpukit/libmisc/shell/shell.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/495#note_123435

 > +  
 > +  /* Create partial command string */
 > +  partial_cmd = malloc(word_len + 1);

The use of malloc in the shell processing is questionable?

--
  
Chris Johns commented on a discussion on cpukit/libmisc/shell/shell.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/495#note_123436

 > +#define RTEMS_SHELL_CMD_SIZE          (128)
 > +#define RTEMS_SHELL_CMD_COUNT         (32)
 > +#define RTEMS_SHELL_PROMPT_SIZE       (128)

Yes


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/495
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250610/ea852cb6/attachment.htm>