LibBSD | Beatnik BSP Fixes (!76)

[Chris Johns (@chris)]

Merge request https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/76 was reviewed by Chris Johns

--
  
Chris Johns started a new discussion on freebsd/sys/kern/uipc_mbuf.c: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/76#note_124754

 >  CTASSERT(sizeof(struct pkthdr) == 56);
 > -#if defined(__powerpc__) && defined(BOOKE)
 > +#if defined(__powerpc__) && defined(BOOKE) && ( defined(__rtems__) && defined(__powerpc64__) )

This modifies an existing line. It is tricky to get right and use the same value. It is a case that does not sit well with our coding standard when handling 3rd party code.

```
#if defined(__LP64__)
CTASSERT(offsetof(struct mbuf, m_dat) == 32);
CTASSERT(sizeof(struct pkthdr) == 64);
CTASSERT(sizeof(struct m_ext) == 160);
#else
CTASSERT(offsetof(struct mbuf, m_dat) == 24);
CTASSERT(sizeof(struct pkthdr) == 56);
#if defined(__powerpc__) && defined(BOOKE)
#if defined(__rtems__)
/* coded this way to make sure the RTEMS define in on a line by itself */
#if defined(__powerpc64__)
/* PowerPC booke has 64-bit physical pointers. */
CTASSERT(sizeof(struct m_ext) == 176);
#else 
CTASSERT(sizeof(struct m_ext) == 172);
#endif
#else /* __rtems__ */
CTASSERT(sizeof(struct m_ext) == 172);
#endif /* __rtems__ */
#else
CTASSERT(sizeof(struct m_ext) == 172);
#endif
#endif
```

I have no idea if this works?

--
  
Chris Johns started a new discussion on rtemsbsd/powerpc/include/linux/genalloc.h: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/76#note_124755

 >  {
 > -	int chunks;
 > +	int chunks, count = 0;

Separate lines for variables

--
  
Chris Johns started a new discussion on rtemsbsd/powerpc/include/linux/kernel.h: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/76#note_124756

 > -	return (x < 0 ? -x : x);
 > -}
 > -

Why can this be removed? What is the error?


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/76
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250617/823e954f/attachment-0001.htm>