RTEMS | bsps/shared/serial/pl011: Avoid unnecessary reads (!519)
Kinsey Moore (@opticron)
gitlab at rtems.org
Thu Jun 19 23:17:29 UTC 2025
Kinsey Moore commented on a discussion on bsps/shared/dev/serial/arm-pl011.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/519#note_124981
> const char ch
> )
> {
> - regs_base->uartdr = PL011_UARTDR_DATA_SET(regs_base->uartdr, ch);
> + regs_base->uartdr = PL011_UARTDR_DATA_SET(0, ch);
There are technically bits above the read or written character that are only valid on read. I have changed the macro used to not take an initial value.
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/519#note_124981
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250619/42909493/attachment.htm>
More information about the bugs
mailing list