RTEMS | Add the support for i2c driver in the aarch64/raspberrypi bsp (!363)
Gedare Bloom (@gedare)
gitlab at rtems.org
Tue Jun 24 20:14:38 UTC 2025
Gedare Bloom started a new discussion on bsps/aarch64/raspberrypi/i2c/raspberrypi-i2c.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_125184
> + device != raspberrypi_bscm5 &&
> + device != raspberrypi_bscm6
> +) {
> + return RTEMS_INVALID_NUMBER;
> +}
> +
> +
> + bus = (raspberrypi_i2c_bus *) i2c_bus_alloc_and_init( sizeof( *bus ) );
> + if ( bus == NULL ) {
> + return RTEMS_NO_MEMORY;
> + }
> +
> + bus_path = rpi_select_bus( device );
> + if ( bus_path == NULL ) {
> + i2c_bus_destroy_and_free( &bus->base );
> + return RTEMS_INVALID_NUMBER;
you can move this block up before you call `i2c_bus_alloc_and_init(), so that in the error case you don't bother with allocating and then destroying the `bus`.
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_125184
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250624/e606b9c8/attachment-0001.htm>
More information about the bugs
mailing list