RTEMS | Cannot obtain dates later than 2100 (!339)

[Gedare Bloom (@gedare)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339 was reviewed by Gedare Bloom

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/main.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120680

 > +  int    argc,
 > +  char **argv
 > +)

Now that this is in sptests, it should be using the traditional `rtems_task Init`

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/sptod.doc: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120681

 > +# SPDX-License-Identifier: BSD-2-Clause
 > +
 > +#  testsuites/psxtests/psxtime/psxtime.doc

not `psx`

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/sptod.doc: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120682

 > +#  The license and distribution terms for this file may be
 > +#  found in the file LICENSE in this distribution or at
 > +#  http://www.rtems.org/license/LICENSE.

We should avoid adding this. Prefer to use the 2-clause BSD license. There should be other examples in the sptests.

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/sptod.doc: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120683

 > +
 > +
 > +

Don't use multiple blank lines.

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/main.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120684

 > +  
 > +
 > +  print_time( "rtems_clock_set          ", the_tod, "\n" );

I would personally prefer tests to be silent unless they're failing.

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/main.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120685

 > +    check_a_tod( &Dates[i] );
 > +    i++;
 > +  }

This would look better as a for loop.

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/sptod.doc: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120686

 > +
 > +directives:
 > ++ gmtime_r

the directive being tested is `rtems_clock_get_tod` and `rtems_clock_set_tod`, not `gmtime_r`.

--
  
Gedare Bloom started a new discussion on testsuites/sptests/sptod/main.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339#note_120687

 > +#include <sys/time.h>
 > +
 > +const char rtems_test_name[] = "PSXTOD";

Not `PSX`


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/339
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250308/48c4e880/attachment-0001.htm>