RTEMS | Add the support for i2c driver in the aarch64/raspberrypi bsp (!363)

Gedare Bloom (@gedare) gitlab at rtems.org
Thu Mar 27 00:23:30 UTC 2025




Gedare Bloom started a new discussion on bsps/aarch64/raspberrypi/i2c/raspberrypi-i2c.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_121826

 > -    {
 > -        while (!(BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) & S_DONE )) {
 > -            while ((BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) & S_RXD ) && (bus->remaining_bytes > 0)) {
 > -                *bus->current_buffer = BCM2835_REG(bus->base_address + BCM2711_I2C_FIFO) & 0xFF;
 > -                bus->current_buffer++;
 > -                bus->remaining_bytes--;
 > -                
 > -                // Check for errors
 > -                if (BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) & (S_CLKT | S_ERR)) {
 > -                    return -EIO;
 > -                }
 > -
 > -            }
 > +static int i2c_polling_read(raspberrypi_i2c_bus *bus){
 > +    while (!(BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) & S_DONE ) && (bus->remaining_bytes > 0)) {
 > +        while ((BCM2835_REG(bus->base_address + BCM2711_I2C_STATUS) & S_RXD ) && (bus->remaining_bytes > 0)) {

these lines are still too long. the format errors should show this also. although we don't yet enforce the formatting for C, we're pretty close. you can use the patch from the format output to fix most of the format style problems.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_121826
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250327/39332e64/attachment-0001.htm>


More information about the bugs mailing list