RTEMS | bsps/arm/realview-pbx-a9: Add safe PL111 framebuffer setup (!477)

[Gedare Bloom (@gedare)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/477 was reviewed by Gedare Bloom

--
  
Gedare Bloom started a new discussion on bsps/arm/realview-pbx-a9/start/fb-config.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/477#note_122739

 > +
 > +
 > +

remove the extra blank lines

--
  
Gedare Bloom started a new discussion on bsps/arm/realview-pbx-a9/start/fb-config.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/477#note_122740

 > +
 > +  printk("regs[4] (upbase) = 0x%08x\n", regs[4]);  
 > +  printk("PL111 LCD controller configured (safe mode)\n");

wrap print statements in debug

--
  
Gedare Bloom started a new discussion on bsps/arm/realview-pbx-a9/start/fb-config.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/477#note_122741

 > +  }
 > +
 > +  uintptr_t base = (uintptr_t)cfg->regs;

prefer to declare the variable at the start of the block:
```
uintptr_t base;
if ( !cfg || !cfg->regs) {
  return;
}

base = (uintptr_t) cfg->regs;
```

--
  
Gedare Bloom started a new discussion on bsps/arm/realview-pbx-a9/start/fb-config.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/477#note_122742

 >    .power_delay_in_us = 100000,
 > +  .framebuffer = (void *)0x7FC00000, //QEMU-safe dummy RAM address
 > +  .regs = (pl111 *)0x70000000, //dummy MMIO base

Is there a good place to add a CPP macro for this special value?
`#define PL111_MMIO_base_qemu (0x70000000)`


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/477
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250521/104d834d/attachment.htm>