RTEMS | cpukit/libcrypt: Add SHA3-512 Keccak Implementation (!687)

[Kinsey Moore (@opticron)]

Kinsey Moore started a new discussion on cpukit/include/crypt.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/687#note_129841

 > +	unsigned int rate;
 > +	unsigned int capacity;
 > +	unsigned int pos;
 > +} sha3_ctx_t;
 > +
 > +void sha3_init(sha3_ctx_t *ctx);
 > +void sha3_update(sha3_ctx_t *ctx, const void *data, size_t len);
 > +void sha3_final(sha3_ctx_t *ctx, uint8_t *out, size_t outlen);
 > +
 > +void _crypt_to64(char *s, unsigned long v, int n);
 > +
 > +/* Dirty hack to re-introduce the C11 memset_s function
 > +*  which is missing from the RTEMS C11 compiler but which
 > +*  is used in the libcrypt functions to securely erase
 > +*  sensitive data after use. 
 > +*/

Please see the coding conventions document linked elsewhere for comment formatting guidelines. This comment references a "dirty hack" and either the comment needs to be cleaned up a bit or possibly the code itself needs to be reworked to be less of a hack if possible (or a better explanation of why this specific code is necessary to accomplish the goal).

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/687#note_129841
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250902/4431e1f4/attachment-0001.htm>