RTEMS | bbb bsp: add gpio handling and adc section (!700)

[Gedare Bloom (@gedare)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700 was reviewed by Gedare Bloom

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/adc/bbb-adc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129988

 > +/**
 > + * Copyright (c) 2015 Ketul Shah <ketulshah1993 at gmail.com>
 > +

delete blank line

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/adc/bbb-adc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129989

 > + * The license and distribution terms for this file may be
 > + * found in the file LICENSE in this distribution or at
 > + * http://www.rtems.org/license/LICENSE.

use 2-clause BSD

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/adc/bbb-adc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129990

 > +/**

add SPDX

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/adc/bbb-adc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129991

 > +void rtems_adc_init(void)
 > +{
 > +

remove blank line here

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/adc/bbb-adc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129992

 > +}
 > +
 > +unsigned int rtems_adc_read_multiple(unsigned int len, unsigned int wait, unsigned int mask, unsigned int data[])

I'd personally prefer `unsigned int *data`

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/adc/bbb-adc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129993

 > +
 > +  unsigned int d;
 > +  for(unsigned int i = 0; i < fifo; i++) {

move the variable declarations to the start of the block (here, it would be the start of the function).

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/gpio/bbb-gpio.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129994

 >  
 > +/* I have unfortunately lost the overview a little ....
 > +*/

delete

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/include/bsp/bbb-adc.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129995

 > +/**

SPDX and 2-clasue BSD boilerplate

--
  
Gedare Bloom started a new discussion on bsps/arm/beagle/include/bsp/bbb-adc.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700#note_129996

 > + * @brief ADC intialization.
 > + */
 > +extern void rtems_adc_init(void);

if these functions are specific to the BBB, I think we want `rtems_beaglebone_adc_init` and similar?


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/700
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250904/c7a1f6b9/attachment-0001.htm>