lwIP | rtemslwip/network_compat: Add gethostname/gethostid (!28)

[Gedare Bloom (@gedare)]

Gedare Bloom commented on a discussion on rtemslwip/common/network_compat.c: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/28#note_130505

 > +static char hostname[_POSIX_HOST_NAME_MAX] = {0};
 > +static int hostname_len = 1;
 > +
 > +int gethostname(char *name, size_t size)
 > +{
 > +    int copy_size = hostname_len;
 > +
 > +    if (name == NULL) {
 > +        errno = EFAULT;
 > +        return -1;
 > +    }
 > +    if (copy_size > size) {
 > +        copy_size = size;
 > +    }
 > +
 > +    memcpy(name, hostname, copy_size);

I would do
```
if (copy_size >= size) {
  copy_size = size - 1;
}
memcpy(name, hostname, copy_size);
name[copy_size] = '\0';
if (size <= hostname_len) {
...
```

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/28#note_130505
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250905/03664953/attachment-0001.htm>