RTEMS | cpukit/dev/can/can-bittiming.c: Do not use abs() on unsigned values (!726)

[Gedare Bloom (@gedare)]

Gedare Bloom commented on a discussion on cpukit/dev/can/can-bittiming.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/726#note_132771

 >      sample_point = 1000 * ( tseg + CAN_CALC_SYNC_SEG - tseg2 ) /
 >          ( tseg + CAN_CALC_SYNC_SEG );
 >  
 > -    sample_point_error = abs( sample_point_nominal - sample_point );
 > +    sample_point_error = sample_point_nominal - sample_point;

I agree. My intuition is that the subtraction needs to be done on signed values, and then it should be `abs`

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/726#note_132771
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250919/1ffac16c/attachment-0001.htm>