lwIP | Add GRETH/GRETH_GBIT driver (!40)

Kinsey Moore (@opticron) gitlab at rtems.org
Tue Apr 28 03:07:46 UTC 2026




Kinsey Moore commented on a discussion on rtemslwip/greth/hw_greth.c: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/40#note_149146

 > -                                 VENDOR_GAISLER, GAISLER_ETHMAC,
 > -                                 ambapp_find_by_idx, NULL);
 > -  if (adev) {
 > -    apb = DEV_TO_APB(adev);
 > -    base_addr = apb->start;
 > -    eth_irq = apb->common.irq;
 > +  adev = (void *) (uintptr_t) ambapp_for_each(
 > +    ambapp_plb(),
 > +    ( OPTIONS_ALL | OPTIONS_APB_SLVS ),
 > +    VENDOR_GAISLER,
 > +    GAISLER_ETHMAC,
 > +    ambapp_find_by_idx,
 > +    &dev_id
 > +  );
 > +  if ( adev ) {
 > +    apb = DEV_TO_APB( adev );

The most recent commit also mixes formatting and functional changes. I would recommend a formatting commit on the original code before doing anything else.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/40#note_149146
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260428/61edeb34/attachment-0001.htm>


More information about the bugs mailing list