lwIP | Add GRETH/GRETH_GBIT driver (!40)
Matteo Concas (@matteo.concas)
gitlab at rtems.org
Thu Apr 30 17:51:53 UTC 2026
Matteo Concas commented on a discussion on rtemslwip/greth/include/greth_phy.h: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/40#note_149329
> +#define GRETH_PHY_EXT_STS_1000T_FD_BIT 13
> +#define GRETH_PHY_EXT_STS_1000T_HD_BIT 12
> +
> +#define GRETH_PHY_EXT_STS_1000X_FD ( 1 << GRETH_PHY_EXT_STS_1000X_FD_BIT )
> +#define GRETH_PHY_EXT_STS_1000X_HD ( 1 << GRETH_PHY_EXT_STS_1000X_HD_BIT )
> +#define GRETH_PHY_EXT_STS_1000T_FD ( 1 << GRETH_PHY_EXT_STS_1000T_FD_BIT )
> +#define GRETH_PHY_EXT_STS_1000T_HD ( 1 << GRETH_PHY_EXT_STS_1000T_HD_BIT )
> +
> /* MII registers */
> -#define GRETH_MII_EXTADV_1000FD 0x00000200 /**< 1000 Mbps FD adv capability */
> -#define GRETH_MII_EXTADV_1000HD 0x00000100 /**< 1000 Mbps HD adv capability */
> -#define GRETH_MII_EXTPRT_1000FD 0x00000800 /**< 1000 Mbps FD partner ability */
> -#define GRETH_MII_EXTPRT_1000HD 0x00000400 /**< 1000 Mbps HD partner ability */
> +#define GRETH_MII_EXTADV_1000FD \
> + 0x00000200 /**< 1000 Mbps FD adv capability \
> + */
That's how it came out from formatting with the RTEMS kernel `_clang_format`. Agreed that it does not look good though, I should probably harmonize how these bitfields are defined with the rest of the file anyway.
--
View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/40#note_149329
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260430/72b33153/attachment-0001.htm>
More information about the bugs
mailing list