RTEMS | bsps/powerpc: The sbrk policy default and the exception frames (!1414)

[Vijay Banerjee (@vijay)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1414 was reviewed by Vijay Banerjee

--
  
Vijay Banerjee started a new discussion on bsps/powerpc/shared/start/sbrk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1414#note_157306

 > +   * does not provide the symbol reads whatever resides at address zero.
 > +   */
 > +  if (BSP_sbrk_policy == NULL || 0 == BSP_sbrk_policy[0]) {

`BSP_sbrk_policy[0] == 0` instead of `0 == BSP_sbrk_policy[0]`?

I see the original code had this direction, but since we are already changing it, correct it we can this time :)

--
  
Vijay Banerjee started a new discussion on testsuites/sptests/spfatal31/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1414#note_157307

 >  }
 >  
 > +#elif PPC_HAS_FPU == 1 && !defined( PPC_MULTILIB_FPU )

PPC_HAS_FPU is undefined for non-PPC boards

Maybe `#if defined(PPC_HAS_FPU) && PPC_HAS_FPU == 1 && ...` ?


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1414
You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/5-d9x34v56ghj8mlgfjv1nk0m7k-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260819/bccecc9b/attachment.htm>