LibBSD | Raspberrypi4b: Add sd card support (!158)

[Christian Mauderer (@c-mauderer)]

Christian Mauderer commented on a discussion on freebsd/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/158#note_157700

 > +	 * interrupts (or SDHCI error interrupts) until the IO is done.
 > +	 */
 > +	if (idx == 0) {
 > +		bus_dmamap_sync(sc->sc_dma_tag, sc->sc_dma_map, sync_op);
 > +
 > +		slot->intmask &= ~DATA_XFER_MASK;
 > +		bcm_sdhci_write_4(sc->sc_dev, slot, SDHCI_SIGNAL_ENABLE,
 > +		    slot->intmask);
 > +	}
 > +
 > +	/*
 > +	 * Start the DMA transfer.  Only programming errors (like failing to
 > +	 * allocate a channel) cause a non-zero return from bcm_dma_start().
 > +	 */
 > +	err = bcm_dma_start(sc->sc_dma_ch, psrc, pdst, len);
 > +	KASSERT((err == 0), ("bcm2835_sdhci: failed DMA start"));

OK. I most likely would have removed the parts of the driver that use the dma with some `#ifdef` instead. But that solution is OK too. It should give a clear error if someone changes the pio_mode.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/158#note_157700
You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/5-8jij2yw8iqzq7zr8clgna7h2z-k/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260821/0587d177/attachment-0001.htm>