RTEMS | cpukit/libblock: Fix resource leak in rtems_nvdisk_initialize (CID 1439297) (!905)

Wayne Thornton (@wmthornton-dev) gitlab at rtems.org
Wed Jan 14 01:30:48 UTC 2026



Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/905 was reviewed by Wayne Thornton

--
  
Wayne Thornton started a new discussion on cpukit/libblock/src/nvdisk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/905#note_138616

 > -  rtems_nvdisk*              nvd;
 > +  rtems_nvdisk* nvd;
 > +  rtems_nvdisk* nvd_start;

It appears to me that throughout the file, you removed formatting and spaces designed for readability. For example, in this line your removed several spaces between rtems_nvdisk*....nvd; and collapsed it to read rtems_nvdisk* nvd;

The spacing in the file was for readability and cohesiveness with other code. I would suggest restoring the spacing throughout the file.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/905
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260114/bffac57e/attachment.htm>


More information about the bugs mailing list