RTEMS | flashdisk.c: Fixed garbage name generation and added memory cleanup (!912)

Prakhar Kumar (@prakhar) gitlab at rtems.org
Thu Jan 22 08:23:25 UTC 2026




Prakhar Kumar commented on a discussion on cpukit/libblock/src/flashdisk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/912#note_139478

 > +    return;
 > +
 > +  uint32_t device;
 > +
 > +  if(fd->devices)
 > +  {
 > +    for(device = 0; device< fd->device_count; device++)
 > +    {
 > +      free(fd->devices[device].segments);
 > +      fd->devices[device].segments = NULL;
 > +    }
 > +  }
 > +  free(fd->devices);
 > +  fd->devices = NULL;
 > +
 > +  free(fd->blocks);

So I thought same here that everything is NULL initialized using calloc so null checking would be redundant. 

But i would want to know your suggestion here.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/912#note_139478
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260122/2356cf41/attachment.htm>


More information about the bugs mailing list