RTEMS | cpukit/libblock: Fixed garbage name generation and added memory cleanup (!912)

[Joel Sherrill (@joel)]

Joel Sherrill commented on a discussion on cpukit/libblock/src/flashdisk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/912#note_139669

 >  #define rtems_fdisk_calc_crc16(_b, _c) \
 >    rtems_fdisk_crc16_factor[((_b) ^ ((_c) & 0xff)) & 0xff] ^ (((_c) >> 8) & 0xff)
 >  
 > +/**
 > + * this describes the current state of mutext initialisation
 > + * whether the mutext on the current stage is initialised or not
 > + */
 > +typedef enum
 > +{
 > +    MUTEX_NOT_INITIALIZED = 0,
 > +    MUTEX_INITIALIZED
 > +} rtems_mutex_state_t;

It looks like it could be a boolean. And it should not use a name like that. Starting with rtems_ implies it is a public API.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/912#note_139669
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260123/97d29c8a/attachment-0001.htm>