RTEMS | cpukit/libblock: memory cleanup and name generation failure(nvdisk) (!906)
Prakhar Kumar (@prakhar)
gitlab at rtems.org
Sat Jan 24 19:16:58 UTC 2026
Prakhar Kumar commented on a discussion on cpukit/libblock/src/nvdisk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/906#note_139938
> #define rtems_nvdisk_calc_crc16(_b, _c) \
> rtems_nvdisk_crc16_factor[((_b) ^ ((_c) & 0xff)) & 0xff] ^ (((_c) >> 8) & 0xff)
>
> +/**
> + * this describes the current state of mutext initialisation
> + * whether the mutext on the current stage is initialised or not
> + */
> +typedef enum
> +{
> + MUTEX_NOT_INITIALIZED = 0,
> + MUTEX_INITIALIZED
> +} rtems_mutex_state_t;
In the other MR I explained why i used enums instead of boolean and since both the MRs were almost similar I used the same logic here to keep the code somewhat same (the changes I made)
And there are no real reason why the name is the way it is named, I just struggle with naming and titles, first i had used rtems_mutex_stage_t and then I changed it to state.
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/906#note_139938
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260124/1129a296/attachment-0001.htm>
More information about the bugs
mailing list