RTEMS | cpukit/libblock: memory cleanup and name generation failure(nvdisk) (!906)

Joel Sherrill (@joel) gitlab at rtems.org
Sat Jan 24 20:00:24 UTC 2026




Joel Sherrill started a new discussion on cpukit/libblock/src/nvdisk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/906#note_139943

 >  
 >    return RTEMS_SUCCESSFUL;
 >  }
 > +
 > +static void rtems_nvdisk_cleanup_helper (rtems_nvdisk *nvd, bool *mutex_initialized)
 > +{
 > +  if(nvd == NULL)
 > +    return;
 > +  if((*mutex_initialized) == false)

@gedare for confirmation but I think there should be a blank line above this and the braces should be on the same line as the if and else. Like:

```
if () {
  ...
} else {
  ...
}
```

Use braces on both the true and false.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/906#note_139943
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260124/606382ea/attachment-0001.htm>


More information about the bugs mailing list