RTEMS Source Builder | devel/safeclib: Update to dynamic pkg-config and bypass tests (!269)

[Chris Johns (@chris)]

Merge request https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/269 was reviewed by Chris Johns

--
  
Chris Johns started a new discussion on rtems/config/devel/safeclib-3.9.1-1.cfg: https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/269#note_153770

 > +#
 > +%source set safeclib https://github.com/rurban/safeclib/releases/download/v%{version}/safeclib-%{version}.tar.gz
 > +%hash sha512 safeclib-%{version}.tar.gz 7b9760737143a121a7208b3568a70d9561db11765c6082dd1ad1323223b7ca545530a4ed489a3d63fde1e98f742bfa85f5659836e04fe1520a45c87fdbc051e5

Please separate the build recipe from the configuration data.

--
  
Chris Johns started a new discussion on rtems/config/devel/safeclib-3.9.1-1.cfg: https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/269#note_153771

 > +%build
 > +  # Extract the BSP name and format the exact pkg-config string
 > +  BSP_NAME=$(basename %{with_rtems_bsp})

Why is building for a BSP been selected over looking into multilib builds? I am wanting to understand use case for `libsafec` ?

--
  
Chris Johns started a new discussion on rtems/config/devel/safeclib-3.9.1-1.cfg: https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/269#note_153772

 > +%build
 > +  # Extract the BSP name and format the exact pkg-config string
 > +  BSP_NAME=$(basename %{with_rtems_bsp})

Please review `config/rtems/rtems-bsp.cfg` as it provides support for handling BSPs and the naming. I prefer that base is used rather than adding explicit logic here.

--
  
Chris Johns commented on a discussion on rtems/config/devel/safeclib-3.9.1-1.cfg: https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/269#note_153773

 > +  # HACK: Erase 'tests' from the Makefile's target directories
 > +  # This safely bypasses the syslog linker error without skipping headers
 > +  sed -i 's/ tests//g' Makefile

Sure. There are other examples of sed use in the RSB that may help.

Maybe a test build on FreeBSD without any GNU tools installed would be good?


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/tools/rtems-source-builder/-/merge_requests/269
You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-1t330x9tdgbgwd6pbeeff7jzl-e/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260705/58a07bb3/attachment-0001.htm>