RTEMS | aarch64/xilinx-zynqmp: Use FDT to define PCIe memory mappings (!1116)

Chris Johns (@chris) gitlab at rtems.org
Thu Mar 12 00:44:20 UTC 2026



Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1116 was reviewed by Chris Johns

--
  
Chris Johns started a new discussion on bsps/aarch64/xilinx-zynqmp/start/bspstart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1116#note_145095

 > +    addr + size,
 > +    AARCH64_MMU_DEVICE
 > +  );

1. Please move to a `static` function called `zynqmp_pcie_init()` .
2. The formatting looks weird in some parts
3. Does this BSP always return an FDT? Please check for a `NULL` being returned other this code becomes a hard crash is the FDT set up is missing or broken.
4. Please provide an example of the FDT source in a comment as a reference?

--
  
Chris Johns started a new discussion on bsps/aarch64/xilinx-zynqmp/start/mmu-config.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1116#note_145096

 > -    .flags = AARCH64_MMU_DEVICE
 > -  }, {
 > -#endif /* ZYNQMP_MMU_PCIE_ENABLE */

Does this break existing users of this BSP?

My guess it does.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1116
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260312/18f68f3d/attachment-0001.htm>


More information about the bugs mailing list