RTEMS | cpukit/libblock: Fix resource leak in rtems_fdisk_initialize (!903)
MITHILESH MATTAPALLI (@mithileshm)
gitlab at rtems.org
Fri Mar 13 13:16:38 UTC 2026
MITHILESH MATTAPALLI commented on a discussion on cpukit/libblock/src/flashdisk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/903#note_145329
> +
> + clean_name[ sizeof( RTEMS_FLASHDISK_DEVICE_BASE_NAME ) - 1 ] += i;
> + unlink( clean_name );
> +
> + rtems_mutex_destroy( &p->lock );
> + if ( p->devices ) {
> + for ( d = 0; d < p->device_count; d++ ) {
> + free( p->devices[ d ].segments );
> + }
> + free( p->devices );
> + }
> + free( p->blocks );
> + free( p->copy_buffer );
> + }
> +
> + if ( fd ) {
You're right, passing `fd` is redundant since it's just an offset of `fds` . I've removed it from the function signature and updated the calls
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/903#note_145329
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260313/0024d4df/attachment-0001.htm>
More information about the bugs
mailing list