RTEMS | cpukit/libblock: Fix resource leak in rtems_fdisk_initialize (!903)
MITHILESH MATTAPALLI (@mithileshm)
gitlab at rtems.org
Fri Mar 13 13:25:42 UTC 2026
MITHILESH MATTAPALLI commented on a discussion on cpukit/libblock/src/flashdisk.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/903#note_145331
> + free( p->devices );
> + }
> + free( p->blocks );
> + free( p->copy_buffer );
> + }
> +
> + if ( fd ) {
> + uint32_t d;
> +
> + if ( fd->devices ) {
> + for ( d = 0; d < fd->device_count; d++ ) {
> + free( fd->devices[ d ].segments );
> + }
> + free( fd->devices );
> + }
> + free( fd->blocks );
Since `fd` is just pointing directly to an index in the allocated array now, it can't be NULL.So, I went ahead and dropped the check
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/903#note_145331
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260313/66421169/attachment-0001.htm>
More information about the bugs
mailing list