RTEMS | docs: fix spelling, grammar, and register names in include folder (!1130)
Mohamed Ayman (@mohamedayman23)
gitlab at rtems.org
Thu Mar 19 14:58:18 UTC 2026
Mohamed Ayman commented on a discussion on bsps/arm/stm32f4/include/bsp/stm32_usart.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1130#note_146211
> #define STM32F4_USART_DR_GET(reg) BSP_FLD32GET(reg, 0, 7)
> #define STM32F4_USART_DR_SET(reg, val) BSP_FLD32SET(reg, val, 0, 7)
> - uint32_t bbr;
> -#define STM32F4_USART_BBR_DIV_MANTISSA(val) BSP_FLD32(val, 4, 15)
> -#define STM32F4_USART_BBR_DIV_MANTISSA_GET(reg) BSP_FLD32GET(reg, 4, 15)
> -#define STM32F4_USART_BBR_DIV_MANTISSA_SET(reg, val) BSP_FLD32SET(reg, val, 4, 15)
> -#define STM32F4_USART_BBR_DIV_FRACTION(val) BSP_FLD32(val, 0, 3)
> -#define STM32F4_USART_BBR_DIV_FRACTION_GET(reg) BSP_FLD32GET(reg, 0, 3)
> -#define STM32F4_USART_BBR_DIV_FRACTION_SET(reg, val) BSP_FLD32SET(reg, val, 0, 3)
> + uint32_t brr;
> +#define STM32F4_USART_BRR_DIV_MANTISSA(val) BSP_FLD32(val, 4, 15)
> +#define STM32F4_USART_BRR_DIV_MANTISSA_GET(reg) BSP_FLD32GET(reg, 4, 15)
> +#define STM32F4_USART_BRR_DIV_MANTISSA_SET(reg, val) BSP_FLD32SET(reg, val, 4, 15)
> +#define STM32F4_USART_BRR_DIV_FRACTION(val) BSP_FLD32(val, 0, 3)
> +#define STM32F4_USART_BRR_DIV_FRACTION_GET(reg) BSP_FLD32GET(reg, 0, 3)
> +#define STM32F4_USART_BRR_DIV_FRACTION_SET(reg, val) BSP_FLD32SET(reg, val, 0, 3)
{width=900 height=446}
{width=900 height=127}
In the first part of the first image, which shows the main source repository, only **BBR** appears in the files I edited. In the second part of the first image, since I ran the command on the entire source code, **BRR** appears and is used in other drivers. This demonstrates that **BRR** is the standard naming convention. It is also used in **STM32H7**, which serves as a design reference for **STM32F4**.
In the second image, I show the changes I made to update the naming in the main source (first part of the first image) from **BBR** to **BRR**.
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1130#note_146211
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260319/0da8f2f7/attachment-0001.htm>
More information about the bugs
mailing list