RTEMS | rtems: Deprecated functions removed from source (!1081)

[Sebastian Huber (@sebhub)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1081 was reviewed by Sebastian Huber

--
  
Sebastian Huber started a new discussion on testsuites/sptests/sp41/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1081#note_146392

 >    rtems_test_assert( counter == 2 );
 >  
 > -  puts( "Init - rtems_iterate_over_all_threads - NULL" );

These are the test cases for the `rtems_iterate_over_all_threads()` function. Why do you remove them?

--
  
Sebastian Huber started a new discussion on cpukit/score/src/iterateoverthreads.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1081#note_146393

 > -/* SPDX-License-Identifier: BSD-2-Clause */

Please read the review comments carefully: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1081#note_143586

You can't remove this function without a deprecation process.

--
  
Sebastian Huber started a new discussion on bsps/arm/beagle/clock/clock.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1081#note_146394

 >    if (sc != RTEMS_SUCCESSFUL) {
 > -    rtems_fatal_error_occurred(0xdeadbeef);
 > +    rtems_fatal(RTEMS_FATAL_SOURCE_BSP, 0xdeadbeef);

The documentation of `RTEMS_FATAL_SOURCE_BSP` says this:
```c
  /**
   * @brief Fatal source for BSP errors.
   *
   * The fatal codes are defined in <bsp/fatal.h>.  Examples are interrupt and
   * exception initialization.
   *
   * @see bsp_fatal_code and bsp_fatal().
   */
  RTEMS_FATAL_SOURCE_BSP = 6,
```
The fatal code is an enumerator of type `bsp_fatal_code` and not an integer literal like `0xdeadbeef`. If you want to use this fatal source, you have to add a unique enumerator for all locations calling `bsp_fatal()`.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1081
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260319/327f9ec0/attachment.htm>