Re: RTEMS | Draft: posix: Add mq_ispriority to mq_attr for per‑queue discipline selection (!1084)

[Xinhong Hu (@aptacc2421)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084 was reviewed by Xinhong Hu

--
  
Xinhong Hu commented on a discussion on cpukit/include/mqueue.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146754

 > +  /** This is the number of messages currently queued */
 >    long mq_curmsgs;
 > +  /** RTEMS extension: waiting discipline (0 = FIFO, 1 = priority) */

I have added #ifdef rtems around mq_ispriority_np as suggested. This is included in commit c55bcf49.

--
  
Xinhong Hu commented on a discussion on testsuites/psxtests/psxmsgq05/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146755

 > +#ifdef HAVE_CONFIG_H

I have added the standard RTEMS copyright header in commit 96a9c1a.

--
  
Xinhong Hu commented on a discussion on testsuites/psxtests/psxmsgq05/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146756

 > +static mqd_t mq;
 > +
 > +/* ========================= Thread ========================= */

I have replaced decorative comments with concise descriptions in commit 96a9c1a. The comments now follow RTEMS style.

--
  
Xinhong Hu commented on a discussion on testsuites/psxtests/psxmsgq05/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146757

 > +    pthread_create( &threads[0], &pattr, receive_thread, (void*)(intptr_t)0 );
 > +
 > +    pthread_create( &threads[1], &pattr, receive_thread, (void*)(intptr_t)1 );

I have added rtems_test_assert after every POSIX call in commit 678e491.

--
  
Xinhong Hu commented on a discussion on spec/build/testsuites/psxtests/grp.yml: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146758

 >  copyrights:
 > -- Copyright (C) 2020 embedded brains GmbH & Co. KG
 > +  - Copyright (C) 2020 embedded brains GmbH & Co. KG

The formatting changes to grp.yml have been reverted in commit 89808e9. The file now matches the upstream version. The separate MR for formatting-only changes will be created if still needed. Please resolve this thread.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260322/84141841/attachment-0001.htm>