LibBSD | powerpc/qoriq: Fix build issues (!131)

[Chris Johns (@chris)]

Chris Johns commented on a discussion on freebsd/sys/powerpc/mpc85xx/mpc85xx.c: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/131#note_147379

 >  		*bar = (uint64_t)ccsr_read4(OCP85XX_LAWBARH(n)) << 32 |
 >  		    ccsr_read4(OCP85XX_LAWBARL(n));
 >  		*sr = ccsr_read4(OCP85XX_LAWSR_QORIQ(n));
 > -	} else if (mpc85xx_is_p20xx()) {
 > -		*bar = (uint64_t)ccsr_read4(OCP85XX_LAWBAR_P20XX(n)) << 12;
 > -		*sr = ccsr_read4(OCP85XX_LAWAR(n));

The original change was added without guards and is not present in the upstream code. The lack of guards has confused the updating and has been one source of issues with this device. There was no accompanying documentation with the change about its use and on what hardware. The MR has been test an MVME2500 and works.

If the original user of this change is actively using these versions of libbsd they can submit an MR with guards and suitable documentation. I see no point in us carrying a change there is no information about, was incorrect when first added and we cannot test.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/131#note_147379
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260330/c9d875c0/attachment.htm>