RTEMS | bsp/arm/tms570: TMS570_MMR_SELECT_GMII_SEL macro needs clean-up (#5593)
Avi Weiss (@thnkslprpt)
gitlab at rtems.org
Thu May 28 07:34:42 UTC 2026
Avi Weiss created an issue: https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5593
## Summary
@sebhub partially cleaned this up with commit 3a0dcd5ee97dd150cdea9d1d2ca06e81f58436fc:
```c
bsp/tms570: Replace TMS570_MMR_SELECT_GMII_SEL
Replace TMS570_MMR_SELECT_GMII_SEL with TMS570_MMR_SELECT_MII_MODE and
TMS570_MMR_SELECT_RMII_MODE.
```
but some further updates are needed with this `TMS570_MMR_SELECT_GMII_SEL` macro.
{width=661 height=330}
## Expected behaviour
First of all `tms570ls3137zwt-pins.h` shouldn't be referencing the macro defined in
`tms570lc4357-pins.h` anymore.
Secondly the 4357 usage needs to actually be fixed properly:
```c
/// (TM) TODO: is this correct? LS3137ZWT uses TMS570_PIN_AND_FNC(TMS570_BALL_WITH_MMR(29, 3), 0)
/// Per the schematic, this pin (called MII_RX_DV / RX_DV) attaches to pad B11 and can select
/// between MII and RMII mode for the PHY. A pin like this is required for the lwip tms570 rtems port
#define TMS570_MMR_SELECT_GMII_SEL TMS570_BALL_B11_MII_RX_DV
```
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5593
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260528/40c12cf8/attachment-0001.htm>
More information about the bugs
mailing list