[rtems commit] PR1908: QoS library for CBS scheduler

[Gedare Bloom]

On Mon, Apr 16, 2012 at 2:33 AM, Ralf Corsepius
<ralf.corsepius at rtems.org> wrote:
> Has there been any prior discussion and review of this patch?
>
Yes although some may have happened offlist. The code has been
available for review at PR1908 since last September.

> At least I am not aware of any such discussion nor review.
>
> * This commit is incomplete:
> cpukit/libqos/preinstall.am is missing
>
OK

> * IMO, the file cpukit/libqos/qreslib.inl doesn't make any sense.
> It is unconditionally included by qreslib.h
>
> * qreslib.h and qreslib.inl are installed into $(includedir).
> We once had agreed upon that all RTEMS specific headers are supposed to be
> installed into $(includedir)/rtems.
>
> I would suggest the installation location to be changed.
>
I have no problem with that.

> * qreslib.inl lacks header guards.
> It is not safe against multiple inclusion.
>
> * qreslib.inl is installed into $(includedir).
> We have a convention to install *.inl's into inline subdirectories.
>
Will see if qreslib.inl stays around or not.

> * I don't like the fact a libqos/ subdirectory is being introduced.
> IMO, these file should go into rtems/include and rtems/inline.
>
That makes sense to me. Somewhat like RM is handled at that level.

> Ralf
>
>
> On 04/16/2012 05:09 AM, gedare at rtems.org wrote:
>>
>> Module:    rtems
>> Branch:    master
>> Commit:    1c2b94a61c3054fbcebb24b3bb49c7649be020b0
>> Changeset:
>> http://git.rtems.org/rtems/commit/?id=1c2b94a61c3054fbcebb24b3bb49c7649be020b0
>>
>> Author:    Petr Benes<petben at petben.net>
>> Date:      Sun Apr 15 23:12:08 2012 -0400
>>
>> PR1908: QoS library for CBS scheduler
>>
>> Add the lipqos and sptest.
>>
>> ---
>>
>>  cpukit/libqos/Makefile.am                    |   12 ++
>>  cpukit/libqos/qreslib.h                      |   81 +++++++++
>>  cpukit/libqos/qreslib.inl                    |  214
>> ++++++++++++++++++++++++
>>  testsuites/sptests/spqreslib/Makefile.am     |   28 +++
>>  testsuites/sptests/spqreslib/init.c          |  227
>> ++++++++++++++++++++++++++
>>  testsuites/sptests/spqreslib/spqreslib.doc   |   22 +++
>>  testsuites/sptests/spqreslib/spqreslib.scn   |   30 ++++
>>  testsuites/sptests/spqreslib/system.h        |   62 +++++++
>>  testsuites/sptests/spqreslib/task_periodic.c |  138 ++++++++++++++++
>>  9 files changed, 814 insertions(+), 0 deletions(-)
>>
>> diff --git a/cpukit/libqos/Makefile.am b/cpukit/libqos/Makefile.am
>> new file mode 100644
>> index 0000000..3223dcd
>> --- /dev/null
>> +++ b/cpukit/libqos/Makefile.am
>> @@ -0,0 +1,12 @@
>> +##
>> +## $Id$
>> +##
>> +
>> +include $(top_srcdir)/automake/multilib.am
>> +include $(top_srcdir)/automake/compile.am
>> +
>> +include_HEADERS = qreslib.h
>> +include_HEADERS += qreslib.inl
>> +
>> +include $(srcdir)/preinstall.am
>> +include $(top_srcdir)/automake/local.am