[PATCH] Add and use kputc()

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Aug 13 15:19:55 UTC 2012


On 08/13/2012 05:09 PM, Joel Sherrill wrote:
> On 08/13/2012 09:57 AM, Sebastian Huber wrote:
>> On 08/13/2012 04:18 PM, Gedare Bloom wrote:
>>> I have no issue with this change but it does "pollute" the public namespace.
>> Yes, everyone using printk() has to deal now also with kputc().  This is not
>> good.  What about rtems_console_putc()?  Maybe we should rename some of the
>> other functions, e.g.
> These aren't console, they are kernel debug output methods. And
> if you rename getchark, you also need to rename printk.

Ok, what about rtems_debug_putc()?

Renaming printk() is difficult since it has a ... parameter.

>
> I don't know that it is much of a pollution. If you want to put rtems_
> in front of them, that's OK but including console is wrong.
>
> If we are heading to a family of debug I/O methods, then they
> all need to be consistent and (very likely) documented better
> than they are currently.

I came up with this kputc() because I have a boot loader which must output 
something, but stay under 16k code space.  For this printk() is too big.

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.





More information about the devel mailing list