Google Code In Patches

Thomas Dörfler Thomas.Doerfler at
Mon Dec 10 08:05:16 UTC 2012


I can not add something substantial to the technical discussion, but...

On 10.12.2012 08:53, Sebastian Huber wrote:
> Hello Cynthia,
> On 12/09/2012 11:08 PM, Cynthia Rempel wrote:
>> Hi,
>> 2. Every time anyone submits a Google Code In patch it receives harsh
>> criticism, which defeats the purpose of encouraging young people to code.
> If someone has problems to handle critique, then he should better start
> to learn it now.

Discussing patches is a normal step to improve the code (and
documnetation). But the discussion should always take into account who
is member (or originator) of the discussion.

The GCI program tries to guide young students to open source projects.
Nobody can expect them to be perfect workers, so they need encouragement
even during critique.

So just a few words of encouragement added to a discussing email may
keep them on track and guide them better to a proper result.

Sebastian: the general tone on the RTEMS lists should IMHO opinion be
polite. I am sure you will agree ;-)



>> 3. The purpose for Doxygen comments is different than regular
>> comments: they are used to generate documentation, not make the code
>> more clear. Documentation is often used in safety, and suitability
>> certification processes.
>> That being said, I simply ask that the directions be simplified.
>> A positive step for criticism would be simple directions on how to get
>> the comments on the source code to generate documentation that will
>> pass safety and suitability certifications.
> Yes, we lack a clear guideline for Doxygen comments.  We should address
> this first.  See also

!!! Neue Adresse !!! New Address !!!
Embedded Brains GmbH
Thomas Doerfler        Dornierstr. 4
D-82178 Puchheim       Germany
email: Thomas.Doerfler at
Phone: +49-89-18 94 741-12
Fax:   +49-89-18 94 741-09

More information about the devel mailing list