[PR 06] LEON3: change d-cache snoop detect implementation

Daniel Hellstrom daniel at gaisler.com
Thu Feb 2 14:46:27 UTC 2012


The previous code only checked if d-cache snooping was implemented,
however snooping may be available but not enabled which may lead
to driver bugs.

Signed-off-by: Daniel Hellstrom <daniel at gaisler.com>
---
 c/src/lib/libbsp/sparc/leon3/startup/bspstart.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/c/src/lib/libbsp/sparc/leon3/startup/bspstart.c b/c/src/lib/libbsp/sparc/leon3/startup/bspstart.c
index 82054e8..c712f84 100644
--- a/c/src/lib/libbsp/sparc/leon3/startup/bspstart.c
+++ b/c/src/lib/libbsp/sparc/leon3/startup/bspstart.c
@@ -36,19 +36,19 @@ extern void amba_initialize(void);
  * set_snooping
  *
  * Read the data cache configuration register to determine if
- * bus snooping is available. This is needed for some drivers so
- * that they can select the most efficient copy routines.
+ * bus snooping is available and enabled. This is needed for some
+ * drivers so that they can select the most efficient copy routines.
  *
  */
 
 static inline int set_snooping(void)
 {
   int tmp;
-  __asm__ (" lda [%1] 2, %0 "
+  __asm__ (" lda [%%g0] 2, %0 "
       : "=r"(tmp)
-      : "r"(0xC)
+      :
   );
-  return (tmp >> 27) & 1;
+  return (tmp >> 23) & 1;
 }
 
 /* ASM-function used to get the CPU-Index on calling LEON3 CPUs */
-- 
1.7.0.4




More information about the devel mailing list